Updated SPIR-T for better pretty-printing (esp. OpExtInst), and started deduplicating custom debuginfo.
#1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially relevant SPIR-T PRs that are included here:
spv.OpFoo(A: imm, B: ID, C: imm, ...)instead ofspv.OpFoo<imms>(IDs). spirt#33#[...]syntax. spirt#35OpNames to replace theT1/F2/v3style, when unambiguous. spirt#36OpExtInstusing officialextinst.*.grammar.jsonand/or customContext-registered ones. spirt#45That last one is the most relevant here, because together with debuginfo deduplication, it causes:
Yes, that's the same function (
sky_shader::henyey_greenstein_phase), but incomprehensible before.